Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MD5 hash function with a non-broken one in Checksum.java #341

Open
kypeli opened this issue Jul 15, 2022 · 2 comments
Open

Replace MD5 hash function with a non-broken one in Checksum.java #341

kypeli opened this issue Jul 15, 2022 · 2 comments

Comments

@kypeli
Copy link

kypeli commented Jul 15, 2022

MD5 is considered a broken cryptographic hash function. Please use some other hash function instead, like SHA-1 or SHA-2.

MD5 is used in this file https://github.com/matomo-org/matomo-sdk-android/blob/master/tracker/src/main/java/org/matomo/sdk/tools/Checksum.java

@d4rken
Copy link
Member

d4rken commented Jul 15, 2022

The SDK does not use the checksum to secure any secrets.
It's purely an identifier for for the APK file.
For this use-case it only matters that it is fast, and collisions are reasonably rare, while old, MD5 still fulfills that 🍻.

I don't see any benefit in changing it, it would also break the existing statistics data for everyone that updates.
I'd argue that this is working as intended.
Thoughts @hannesa2 ?

@hannesa2
Copy link
Collaborator

It's purely an identifier for for the APK file.

As long as it's not a real security issue, all is fine.
Sure, I would not say, it will never done.
I see this as an open source project, where everyone is warmly welcome to improve it with pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants