get test to pass

matomo-org · Feb 15, 2024 · e4dc4de · e4dc4de
1 parent 6024893
commit e4dc4de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/data.ts b/src/data.ts
@@ -179,12 +179,12 @@ function getReportData(request: GoogleAppsScript.Data_Studio.Request<ConnectorPa
   const report = request.configParams.report;
   const segment = request.configParams.segment || '';
 
-  const filter_limit = request.configParams.filter_limit
-    ? parseInt(request.configParams.filter_limit, 10)
-    : -1;
-
-  if (!filter_limit) {
-    throwUserError(`Invalid default row limit ${filter_limit} supplied.`);
+  let filter_limit = -1;
+  if (request.configParams.filter_limit) {
+    filter_limit = parseInt(request.configParams.filter_limit, 10);
+    if (filter_limit <= 0 || Number.isNaN(filter_limit)) {
+      throwUserError(`Invalid default row limit ${filter_limit} supplied.`);
+    }
   }
 
   let rowsToFetchAtATime = parseInt(env.MAX_ROWS_TO_FETCH_PER_REQUEST, 10) || 100000;

diff --git a/tests/appscript/data.spec.ts b/tests/appscript/data.spec.ts
@@ -335,7 +335,7 @@ describe('data', () => {
     });
 
     for (let limit of ['-1', '0', 'sadlfjk']) {
-      it('should fail if an invalid filter_limit is specified', async () => {
+      it(`should fail if an invalid filter_limit is specified (${limit})`, async () => {
         await expect(async () => {
           await Clasp.run('getData', {
             configParams: {