-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Hardcoding more than once is error prone #66
Comments
It would also be more consistent with the rest of the API. Technically, if we'd change the argument to expect a SymbolicExpression, the former notation with a string would still work due to the implicit cast from string to the expression. We'd need to verify it also works with the params array overload though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think hardcoding "x" more than once should be avoided because it is error prone. It potentially causes runtime errors.
My suggestion is as follows:
Any comments are welcome. Thank you.
The text was updated successfully, but these errors were encountered: