Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to correspond with the changes for mathjax/MathJax#3300 #1164

Merged
merged 10 commits into from
Nov 18, 2024

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Nov 15, 2024

This PR fixes the tests to handle the changes from #1146 that resolved mathjax/MathJax#3300. These are mostly changes for the removal of mstyle elements that are no longer needed, or the removal of some displaystyle or scriptlevel attributes that are redundant.

Some newcommand tests still fail, but they will pass with the PR that updates the \let command (I'm preparing it now).

@dpvc dpvc requested a review from zorkow November 15, 2024 21:13
@dpvc dpvc added this to the v4.0 milestone Nov 15, 2024
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, 6 newcommand tests are still failing.
Otherwise looks good.

@dpvc
Copy link
Member Author

dpvc commented Nov 18, 2024

The PR that fixes those is available now as #1165.

@dpvc dpvc merged commit b5c184b into develop Nov 18, 2024
@dpvc dpvc deleted the fix/3300-tests branch November 18, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants