CharacterEncoding Rule with ToString unimplemented #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But let's at least not crash when it is used.
mmatera
reviewed
Apr 18, 2021
| encoding = options["System`CharacterEncoding"] | ||
| text = value.format(evaluation, form.get_name(), encoding=encoding) | ||
| if form.has_form("Rule", 2) and form.leaves[0] == Symbol("System`CharacterEncoding"): | ||
| return evaluation.message("ToString", "encoding") |
There was a problem hiding this comment.
I think before this message, an if clause checking that encoding is not available is missing. Otherwise, the next line is never executed.
rocky
force-pushed
the
master
branch
2 times, most recently
from
b007e8c
to
ef16eb6
Compare
rocky
force-pushed
the
master
branch
5 times, most recently
from
8367d69
to
83bb068
Compare
rocky
force-pushed
the
master
branch
2 times, most recently
from
9570fdd
to
499f1bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But let's at least not crash when it is used.