Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin python 3.12 in CI and requires-python #4102

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

DanielYang59
Copy link
Contributor

Summary

@shyuep shyuep enabled auto-merge (squash) October 10, 2024 18:47
@JaGeo
Copy link
Member

JaGeo commented Oct 13, 2024

The last set of tests never started. Thus, we are stuck here. Any thoughts, @DanielYang59 ?

@DanielYang59
Copy link
Contributor Author

DanielYang59 commented Oct 13, 2024

The last set of tests never started. Thus, we are stuck here.

I don't know the exact reason, but my guess is the unstarted set is the cached set for our current config (python > 3.10 for Ubuntu). As the finished number of tests is exactly what we asked 42 successful, 1 skipped, and 10 expected checks, the last 10 expected checks look like some kind of "ghost" from previous cache. The check panel, however, does reflect this real number of tests required.

I didn't find any related reports in GitHub Community so I might open one later, https://github.com/orgs/community/discussions/141301

auto-merge was automatically disabled October 13, 2024 13:02

Head branch was pushed to by a user without write access

@DanielYang59 DanielYang59 changed the title pin python 3.12 in CI pin python 3.12 in CI and requires-python Oct 13, 2024
@ab5424
Copy link
Contributor

ab5424 commented Oct 13, 2024

@DanielYang59 @JaGeo I think that the branch protection rules require a check under the name test (ubuntu-latest, >3.10, lowest-direct, ci,optional) to pass (hence the "Required" tag at the end of the line) but since that doesn't exist anymore so it can't report its status. I saw the same thing in one of my projects. The only workaround I know is to temporarily remove that rule from the repo setting.

@DanielYang59
Copy link
Contributor Author

DanielYang59 commented Oct 14, 2024

@ab5424 Bravo! you are the savior.

I think that the branch protection rules require a check under the name

I don't have write access to the repo, but sounds like the branch protection rules are dynamically generated based the test matrix config from the master branch?

The only workaround I know is to temporarily remove that rule from the repo setting.

Maintainers should be able to do a manual (force) merge not using auto-merge? @shyuep

@DanielYang59
Copy link
Contributor Author

For some reason I'm still seeing "ghost" expected checks from other PR where the config should have been updated on master branch, perhaps the branch protection rule is hard coding to expect ubuntu-latest, >3.10? I cannot check myself as I don't have access

@shyuep shyuep enabled auto-merge (squash) October 21, 2024 20:58
@shyuep shyuep disabled auto-merge October 21, 2024 20:58
@shyuep shyuep merged commit 9424d5f into materialsproject:master Oct 21, 2024
43 checks passed
@DanielYang59 DanielYang59 deleted the real-pin-python312-ci branch October 22, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants