-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump chgnet
to support numpy 2, skip failing matgl
test for torch
2.4.1
#4101
Conversation
Seem to be related to DGL doesn't have that particular shared object for torch 2.4.1:
should be related to dmlc/dgl#7247 and materialsvirtuallab/matgl#296
|
chgnet
to support numpy 2
chgnet
to support numpy 2chgnet
to support numpy 2
chgnet
to support numpy 2chgnet
to support numpy 2, skip failing matgl
test for torch
2.4.1
Since chgnet is already implemented in matgl, I would rather we unify support for everything that matgl supports using matgl. |
Great to know, thanks! But I don't any experience with matgl or chgnet, perhaps need someone with more expertise on this to migrate the implementation |
Summary
chgnet
to support Numpy2Conflicting
torch
versionchgnet 0.4.0
requirestorch > 2.4.1
to be NumPy2 compatible Support NumPy 2 CederGroupHub/chgnet#202 (comment)matgl
requirestorch <= 2.2.1
fordgl
to work correctly bumpchgnet
to support numpy 2, skip failingmatgl
test fortorch
2.4.1 #4101 (comment)Should we skip two failing tests for
matgl
here as I assume this should be fixed from thedgl
side?Input appreciated.