-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to pytorch
installation with uv
in CI
#3826
Revert to pytorch
installation with uv
in CI
#3826
Conversation
pytorch
installation with uv
pytorch
installation with uv
in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @DanielYang59! 👍
Looks like we still have the issue where To fix this, we might need to install Before this PR, even after |
we're getting
which is not a torch related error message? strange that it only happens on the 1st runner. maybe a race condition? we could try |
at least it's no longer failing due to timeouts. looks like now we're hitting this issue astral-sh/uv#2586 |
Look like this one. I guess we would need to still install Maybe we could try to install everything but Or, just fall back to slow but reliable |
570ba5c
to
f6eec5c
Compare
f6eec5c
to
4e5e9de
Compare
e3fbc67
to
41e6d99
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
b21a6f1
to
10ff49c
Compare
@@ -74,15 +74,16 @@ jobs: | |||
micromamba install -n pmg -c conda-forge bader enumlib openff-toolkit packmol pygraphviz tblite --yes | |||
|
|||
- name: Install pymatgen and dependencies via uv | |||
env: | |||
UV_HTTP_TIMEOUT: 300 # torch could easily timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems pip install torch
is quite flaky as well, and i don't think it's to be fixed anytime soon:
Occasional timeouts will happen.
but they suggesting increasing the timeout for pip instead, perhaps we could do the same to uv
: https://docs.astral.sh/uv/configuration/environment/
HTTP_TIMEOUT (or UV_HTTP_TIMEOUT): If set, uv will use this value (in seconds) as the timeout for HTTP reads (default: 30 s).
Closing this one in #4100, reason: currently |
Summary
Revert to install
torch
withuv
Also link to #4063,
pip install torch
is taking up 70% of the total dep install timeRevert to
pytorch
installation withuv
in CI,unexpected end of file
during wheel download astral-sh/uv#2586:UV_INDEX_URL
with AWS CodeArtifact index consistently fails on large packages astral-sh/uv#4402.