Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Unit test of boltztrap2 generate files inplace #4040

Open
1 of 2 tasks
DanielYang59 opened this issue Sep 5, 2024 · 0 comments · May be fixed by #4095
Open
1 of 2 tasks

[CI] Unit test of boltztrap2 generate files inplace #4040

DanielYang59 opened this issue Sep 5, 2024 · 0 comments · May be fixed by #4095
Labels
dx Developer experience tests Issues with or changes to the pymatgen test suite

Comments

@DanielYang59
Copy link
Contributor

DanielYang59 commented Sep 5, 2024 •
edited
Loading

Should use temporary scratch directory such that unit test wouldn't generate files inplace.

Test of boltztrap2 generate files locally:

  • TestBztTransportProperties generate bztTranspoPros.json.gz
  • TestBztInterpolator generates bztinterp.json.gz
@DanielYang59 DanielYang59 changed the title [CI] Unit test of boltztrap2 generate file inplace [CI] Unit test of boltztrap2 generate files inplace Sep 5, 2024
@janosh janosh added tests Issues with or changes to the pymatgen test suite dx Developer experience labels Sep 5, 2024
@DanielYang59 DanielYang59 linked a pull request Oct 4, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dx Developer experience tests Issues with or changes to the pymatgen test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent unit test of boltztrap2 from modifying files in place DanielYang59/pymatgen
2 participants
@janosh @DanielYang59