Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix bump phonopy #1006

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Oct 4, 2024

Changes

  1. Update phonopy version
  2. Switch off the Gruneisen parameter computations at gamma point following (Gruneisen API results different when updating phonopy from v2.27.0 to >=v2.28  phonopy/phonopy#455 (comment))

Todo

  • Investigate what cause the change in gruneisen parameter value leading to failure in test
  • Fix failing phonon workflow with using latest phonopy version (v2.30.1)

@naik-aakash naik-aakash marked this pull request as draft October 4, 2024 11:13
@naik-aakash
Copy link
Contributor Author

Hi @JaGeo ,

I had a look at the phonopy source code changes between v2.28 and v.2.27, I could not really pinpoint what is causing the issue with different values of the average Gruneisen parameter here.

I guess it has something to do with following PR. But am not sure about it

phonopy/phonopy@c013a19

@JaGeo
Copy link
Member

JaGeo commented Oct 6, 2024

How large are the changes? Could you give more details? Thanks!

@naik-aakash
Copy link
Contributor Author

The average Gruneisen value now comes out to be 1.271535057337552 using v2.28 (using v2.27 we used to get 1.1882292157682082)

@JaGeo
Copy link
Member

JaGeo commented Oct 6, 2024

Yeah, I think we need a bit more analysis here. This is quite a large change

@naik-aakash
Copy link
Contributor Author

The latest version of phonopy causes phonon workflow test to also fail (cause of failure seems to originate from force constants computation default being changed)

@JaGeo
Copy link
Member

JaGeo commented Nov 18, 2024

I would need more details to act. E.g., How large is the change? Why does this only affect the Grüneisen parameter workflow? What is different?

We can do this privately if you prefer.

@naik-aakash
Copy link
Contributor Author

I would need more details to act. E.g., How large is the change? Why does this only affect the Grüneisen parameter workflow? What is different?

We can do this privately if you prefer.

As I have mentioned above, now with latest version phonon workflow test is also affected. I will try to share the details in next days

@JaGeo
Copy link
Member

JaGeo commented Nov 18, 2024

@naik-aakash i see! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants