Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 fatal error due to simple_html_dom #2

Closed
andrewcsp opened this issue May 24, 2024 · 1 comment
Closed

PHP 8.3 fatal error due to simple_html_dom #2

andrewcsp opened this issue May 24, 2024 · 1 comment

Comments

@andrewcsp
Copy link

I've noticed that the PageShrink doesn't work in PHP 8.3 due to an issue with the simple_html_dom dependency noted here: voku/simple_html_dom#110

The specific error I'm seeing is:
PHP Fatal error: Uncaught TypeError: Cannot assign null to property DOMElement::$id of type string in /home/<user>/<core>/components/pageshrink/model/vendor/voku/simple_html_dom/src/voku/helper/AbstractSimpleHtmlDom.php:174

Running PHP 8.3.6 with MODX 2.8.7 and PageShrink 1.0.3
@matdave
Copy link
Owner

matdave commented Sep 4, 2024

I've upgraded to the latest version of voku/simple_html_dom

@matdave matdave closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewcsp @matdave