Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Blackfriday issue; provides explicit v2 #68

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rickb777
Copy link

This PR removes all reference to gopkg.in origin for blackfriday, because it is problematic. Direct reference to blackfriday via github.com works fine.

Also this PR adds a v2 folder, in line with the Go modules specification for semver versioned code that is > v1.

When merging, please note that the first line of go.mod should stay matcornic, i.e.

module github.com/matcornic/hermes/v2

This PR should resolve issue #67 .

@rickb777
Copy link
Author

Perhaps the last v1 code ought to be re-instated in the top-level folder. Also, it is possible to handle v2, v3 ... etc using tags instead of folders.

See https://blog.golang.org/v2-go-modules

@ghost
Copy link

ghost commented Nov 14, 2020

please accept this

@Z-a-r-a-k-i
Copy link

Z-a-r-a-k-i commented Nov 19, 2020

I guess it won't be accepted until the codebeat gets green.
Waiting for a satisfying solution for @matcornic we have to add replace gopkg.in/russross/blackfriday.v2 => github.com/russross/blackfriday/v2 v2.0.1 into go.mod, I hope that there won't be any other side-effect

edit: nvm doesn't work on go mod tidy (go: github.com/russross/blackfriday/[email protected] used for two different module paths (github.com/russross/blackfriday/v2 and gopkg.in/russross/blackfriday.v2), what the heck I can't find any single way to make it work. Should we consider this package as deprecated and use some less cool alternatives ?

edit: nvm again => #67 (comment)

TLDR: using import "github.com/matcornic/hermes/v2" instead of import "github.com/matcornic/hermes fixed the issue for me

@ChronosMasterOfAllTime
Copy link

fixed in https://github.com/go-hermes/hermes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants