Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP-Parser not in direct dependencies, PHP-Parser > 5.0 is incompatible #273

Open
danbka33 opened this issue Mar 15, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@danbka33
Copy link

Describe the bug

A new release of PHP-Parser has recently been released.
https://github.com/nikic/PHP-Parser/releases/tag/v5.0.0

In the changelog you can see that the "create" method that was used has been removed. This method is used in this file:

$parser = (new ParserFactory())->create(ParserFactory::PREFER_PHP7);

This package is not listed in direct dependencies, so it is allowed to install version 5, which is not compatible.

Options

  1. Add version 4 to direct dependencies.
  2. Go to version 5, add this to direct dependencies and fix the creation method.
@danbka33 danbka33 added the bug Something isn't working label Mar 15, 2024
@matchish matchish added the help wanted Extra attention is needed label Mar 15, 2024
@matchish matchish removed the help wanted Extra attention is needed label May 14, 2024
@matchish
Copy link
Owner

v7.6.1 should fix the issue. could you provide a feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants