Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow footer navigation modification via app.config #39

Open
MrDoekje opened this issue Jan 14, 2025 · 3 comments
Open

Allow footer navigation modification via app.config #39

MrDoekje opened this issue Jan 14, 2025 · 3 comments

Comments

@MrDoekje
Copy link
Contributor

Currently, anyone interested in changing the navigation links would need to modify the source of their directory.

However, right now the footer uses the tags in the app.config to determine what links to show. I'm not sure how this could easily be made in a generic way but would suggest to (for now) just have it be manual. I imagine people might want full control of what links to show anyway.

If you agree with the idea I'll create a pull request.

@masterkram
Copy link
Owner

Hey @MrDoekje, can you explain a bit more what you mean by "have it manual"? I do agree that the configuration of the footer is a bit restrictive in terms of what you can change.


Note on tags:

Tags pages (eg):
Screenshot 2025-01-14 at 17 53 16

It's important to note that the links in the footer are important in the current implementation because when the site is generated nuxt crawls starting from the index page based on this config we have in the nuxt.config.ts. The tags pages were relying on the footer to be linked to and crawled. So we need to change the nuxt config such that the tags pages are always rendered.

  nitro: {
    prerender: {
      failOnError: false,
      crawlLinks: true,
      routes: ["/", "/sitemap.xml"],
    },
  },

@MrDoekje
Copy link
Contributor Author

With 'it being manual' I mean a user configures the links that are shown in the footer from the app.config e.g.;

Screenshot 2025-01-15 at 11 04 16

(If the footer is used for crawling that means that currently not every directory submission might be crawled anyway, som might not have the tags that are in 'the top 4' of the tags.)

I'm not sure if nuxt has access to the app.config in the nuxt.config, but I think we might be able to make sure that all of the tags in the app.config are always crawled by nuxt

@masterkram
Copy link
Owner

I think it's a good idea, feel free to make a pull request @MrDoekje. Thank you very much. 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants