Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient contrast for WCAG in button hover states #869

Open
tkoleary opened this issue Jan 3, 2020 · 1 comment
Open

Insufficient contrast for WCAG in button hover states #869

tkoleary opened this issue Jan 3, 2020 · 1 comment

Comments

@tkoleary
Copy link
Contributor

tkoleary commented Jan 3, 2020

-Mayflower React
-Component: ButtonSearch

Screenshot 2020-01-03 12 03 48

In ButtonWithIcon the text stays white on hover, but here it is changing to green which has insufficient contrast. It looks like an oversight, in any event it's an easy fix I'd be happy to contribute.

@clairesunstudio
Copy link
Contributor

clairesunstudio commented Jan 17, 2020

Good catch! ButtonSearch is a variant of ButtonWithIcon since #81. The issue I think is that ButtonSearch should have its own usages instead of inheriting the ButtonWithIcon usages

See #261 for the button search options and corresponding classes.

Let me know if you would like to create a pull request. This might not be as straight forward as we will have to customize the usages for a variant. So I'm also happy to work on a fix and maybe you can review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants