-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insufficient contrast for WCAG in button hover states #869
Comments
Good catch! ButtonSearch is a variant of ButtonWithIcon since #81. The issue I think is that ButtonSearch should have its own usages instead of inheriting the ButtonWithIcon usages
See #261 for the button search options and corresponding classes. Let me know if you would like to create a pull request. This might not be as straight forward as we will have to customize the usages for a variant. So I'm also happy to work on a fix and maybe you can review it. |
-Mayflower React
-Component: ButtonSearch
In ButtonWithIcon the text stays white on hover, but here it is changing to green which has insufficient contrast. It looks like an oversight, in any event it's an easy fix I'd be happy to contribute.
The text was updated successfully, but these errors were encountered: