Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Users.update and other routes should have whitelisted parameters to be updated #882

Open
BradHN1 opened this issue Jan 15, 2024 · 0 comments
Assignees
Labels
API API bug Something isn't working

Comments

@BradHN1
Copy link
Contributor

BradHN1 commented Jan 15, 2024

Describe the bug
In testing for security flaws, George Hughey determined that a malicious user could update parameters in the UserProfile model, which in some cases caused a community site not to load. In his particular case he updated a user_type parameter to be a non-valid json string, which when not intermpreted properly caused the canary site not to load. He suggested whitelisting just those parameters that the frontend needs to be able to set.

The same consideration applies to other .update routes for Community, Team, etc.

@BradHN1 BradHN1 added bug Something isn't working API API labels Jan 15, 2024
@BradHN1 BradHN1 moved this to Product Backlog in MassEnergize Software Jan 15, 2024
@BradHN1 BradHN1 moved this from Product Backlog to Sprint Backlog in MassEnergize Software Jan 25, 2024
@apowelka apowelka moved this from Sprint Backlog to Product Backlog in MassEnergize Software Mar 4, 2024
@vschiniah vschiniah self-assigned this Jul 19, 2024
@vschiniah vschiniah moved this to Product Backlog in MassEnergize Software Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants