Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds DNS and websites deployment commands #64

Open
peterjah opened this issue Dec 5, 2022 · 2 comments
Open

adds DNS and websites deployment commands #64

peterjah opened this issue Dec 5, 2022 · 2 comments
Labels

Comments

@peterjah
Copy link
Collaborator

peterjah commented Dec 5, 2022

Need:
Two new commands

  1. Set en DNS entry:

    examples:
    npx @massalabs/sc-toolkit dns --set toto.massa
    optionnal flags:
    --rpc
    --dnsAddress
    --privateKey (?)

  2. Deploy website:

    examples:
    npx @massalabs/sc-toolkit deployWebsite mywebsite.zip
    optionnal flags:
    --rpc
    --dnsAddress
    --privateKey (?)

For private key, several possibilities:

  • pass it as flag arg
  • read in .env file
  • read exported data from Thyra (possible? with password?)

dependencies:
All these features uses the smart contract deployer. in order to do clean stuffs we have to factorize this.
There is already a big part of the work which is already done here: https://github.com/massalabs/massa-sc-utils
We should use it, and adapt for our needs. This should also be nice to add a command line feature for these tools
(i.e npx massa-utils deploy mycontract.wasm") to be use in npm script "deploy": "massa-utils deploy"

We need to clarify the difference between deploying a SC directly and deploying a SC through a deployment contract.
It will be good to decide of an appropriate wording about this

brainstorming option names for the 'deploy through a deployer smarcontract' use case:
--generate-deployer
--deploy-function
--createSC

I propose to generalize the use of typescript. (vanilla javascript forbidden) @massalabs/massa-sc-utils is already a typescript module

@loonggamma
Copy link
Contributor

@peterjah can you give me a bit more context on this one? What is the use-case for a sc-developer who uses the sc-initializer?

@peterjah
Copy link
Collaborator Author

Its not for SC builders only, but anyone who wants to add a DNS entry or upload a website using command line instead of Thyra.

@BatiGencho BatiGencho self-assigned this Mar 8, 2023
@BatiGencho BatiGencho removed their assignment Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants