Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an HTTP CONNECT proxy for the blockchain node #636

Closed
wants to merge 11 commits into from

Conversation

mcamou
Copy link
Contributor

@mcamou mcamou commented Nov 21, 2024

Description

This PR partially fixes #619. The other part is actually creating the blockchain node.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@mcamou mcamou marked this pull request as draft November 21, 2024 18:05
@mcamou mcamou force-pushed the mc/add-connect-proxy branch from 58b188d to b7a66ed Compare November 21, 2024 18:10
@mcamou mcamou changed the title Add the HTTP CONNECT proxy for the Cosmos node feat: Add the HTTP CONNECT proxy for the Cosmos node Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 34.18367% with 129 lines in your changes missing coverage. Please review.

Project coverage is 12.08%. Comparing base (303f6c6) to head (6f29462).

Files with missing lines Patch % Lines
pkg/network/discover.go 26.66% 55 Missing ⚠️
pkg/network/proxy.go 50.00% 36 Missing and 10 partials ⚠️
pkg/config/app.go 0.00% 10 Missing ⚠️
cmd/masa-node/main.go 0.00% 8 Missing ⚠️
node/oracle_node.go 0.00% 5 Missing ⚠️
pkg/config/options.go 0.00% 2 Missing and 1 partial ⚠️
node/options.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   11.23%   12.08%   +0.85%     
==========================================
  Files          93       94       +1     
  Lines        6640     6768     +128     
==========================================
+ Hits          746      818      +72     
- Misses       5834     5880      +46     
- Partials       60       70      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcamou mcamou force-pushed the mc/add-connect-proxy branch from 9dd2ebd to 71d177c Compare November 28, 2024 11:15
@mcamou
Copy link
Contributor Author

mcamou commented Nov 28, 2024

I've tested this as just a CONNECT proxy, the only thing left is to actually check with @restevens402 's Cosmos node to see whether it actually makes any good or not.

@mcamou mcamou changed the title feat: Add the HTTP CONNECT proxy for the Cosmos node feat: Add an HTTP CONNECT proxy for the Cosmos node Nov 28, 2024
@mcamou mcamou changed the title feat: Add an HTTP CONNECT proxy for the Cosmos node feat: Add an HTTP CONNECT proxy for the blockchain node Nov 28, 2024
@mcamou mcamou force-pushed the mc/add-connect-proxy branch from a614483 to 7c34cd9 Compare November 29, 2024 17:26
@mudler
Copy link
Contributor

mudler commented Dec 10, 2024

As this proved to not be working because of technical limitations, we are moving away to this other implementation suggested here: #619 (comment)

@mudler mudler closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spike: interoperability between Cosmos SDK and libp2p
2 participants