Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): Remove the AppConfig and KeyManager singletons #625

Merged
merged 14 commits into from
Nov 12, 2024

Fix compilation error introduced by last commit

d97c7a4
Select commit
Loading
Failed to load commit list.
Merged

chore(cleanup): Remove the AppConfig and KeyManager singletons #625

Fix compilation error introduced by last commit
d97c7a4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 12, 2024 in 0s

0.55% of diff hit (target 8.99%)

View this Pull Request on Codecov

0.55% of diff hit (target 8.99%)

Annotations

Check warning on line 11 in cmd/masa-node/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/config.go#L11 

Added line #L11 was not covered by tests

Check warning on line 22 in cmd/masa-node/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/config.go#L13-L22 

Added lines #L13 - L22 were not covered by tests

Check warning on line 34 in cmd/masa-node/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/config.go#L31-L34 

Added lines #L31 - L34 were not covered by tests

Check warning on line 66 in cmd/masa-node/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/config.go#L66 

Added line #L66 was not covered by tests

Check warning on line 83 in cmd/masa-node/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/config.go#L83 

Added line #L83 was not covered by tests

Check warning on line 40 in cmd/masa-node/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/main.go#L37-L40 

Added lines #L37 - L40 were not covered by tests

Check warning on line 46 in cmd/masa-node/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/main.go#L46 

Added line #L46 was not covered by tests

Check warning on line 57 in cmd/masa-node/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/main.go#L57 

Added line #L57 was not covered by tests

Check warning on line 67 in cmd/masa-node/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/main.go#L67 

Added line #L67 was not covered by tests

Check warning on line 76 in cmd/masa-node/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/main.go#L76 

Added line #L76 was not covered by tests

Check warning on line 101 in cmd/masa-node/main.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/main.go#L101 

Added line #L101 was not covered by tests

Check warning on line 15 in cmd/masa-node/staking.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/staking.go#L15 

Added line #L15 was not covered by tests

Check warning on line 18 in cmd/masa-node/staking.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/staking.go#L18 

Added line #L18 was not covered by tests

Check warning on line 24 in cmd/masa-node/staking.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/staking.go#L24 

Added line #L24 was not covered by tests

Check warning on line 89 in cmd/masa-node/staking.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/masa-node/staking.go#L88-L89 

Added lines #L88 - L89 were not covered by tests

Check warning on line 162 in node/options.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/options.go#L159-L162 

Added lines #L159 - L162 were not covered by tests

Check warning on line 168 in node/options.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/options.go#L165-L168 

Added lines #L165 - L168 were not covered by tests

Check warning on line 174 in node/options.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/options.go#L171-L174 

Added lines #L171 - L174 were not covered by tests

Check warning on line 180 in node/options.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/options.go#L177-L180 

Added lines #L177 - L180 were not covered by tests

Check warning on line 105 in node/oracle_node.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/oracle_node.go#L105 

Added line #L105 was not covered by tests

Check warning on line 182 in node/oracle_node.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/oracle_node.go#L182 

Added line #L182 was not covered by tests

Check warning on line 248 in node/oracle_node.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/oracle_node.go#L248 

Added line #L248 was not covered by tests

Check warning on line 338 in node/oracle_node.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/oracle_node.go#L335-L338 

Added lines #L335 - L338 were not covered by tests

Check warning on line 350 in node/oracle_node.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

node/oracle_node.go#L350 

Added line #L350 was not covered by tests

Check warning on line 784 in pkg/api/handlers_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/api/handlers_data.go#L784 

Added line #L784 was not covered by tests
View more details on Codecov