-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github actions for MinGW #211
Comments
For the thread attribute, it might work with the latest libsodium as I see a change around that in randombytes_internal_random.c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had a quick look after this discussion but there are a bit too many issues for me to fix them cleanly in a PR right now.
With the following change in the ci.yml:
Triggers some errors:
'thread' attribute directive ignored [-Werror=attributes]
for gcc on Windowserror: unknown attribute 'thread' ignored [-Werror,-Wunknown-attributes]
for clang on Windowsunknown-pragmas
for both due to the usage of#pragma comment( lib, "WS2_32.lib" )
I did not try to fix those cleanly in the premake5 as I integrated yojimbo in my own CMake instead. The changes I had to do there are some extra "-Wno-" for the above and a few more issues and linking against ws2_32 and Qwave from the CMake instead of by pragma.
The text was updated successfully, but these errors were encountered: