Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical video aspect ratios are broken #4

Open
Roxxers opened this issue Aug 10, 2021 · 7 comments · May be fixed by #41
Open

Vertical video aspect ratios are broken #4

Roxxers opened this issue Aug 10, 2021 · 7 comments · May be fixed by #41
Labels
bug Something isn't working

Comments

@Roxxers
Copy link

Roxxers commented Aug 10, 2021

Issue from the abandoned upstream TheAMM#82

@marzzzello
Copy link
Owner

marzzzello commented Aug 10, 2021

Does this problem only occur when rotation is set to 90 degrees?
And is it always occurring?

@Roxxers
Copy link
Author

Roxxers commented Aug 10, 2021

I quickly checked like 10 different files. I was able to find one without Rotation: 90 and that works correctly. So it does seem to be only videos with the rotation set to 90 degrees

@marzzzello
Copy link
Owner

I can not reproduce this.
I used exiftool -rotation=90 vid.mp4 to set the rotation flag on some videos.
Either the thumbnails work correctly (rotated too) or the thumbnails are squeezed.
But I don't get completely unusable thumbnails like in the screenshot from the issue you linked

@Roxxers
Copy link
Author

Roxxers commented Aug 10, 2021

That's strange. I can recreate it using the steps you just posted on any video, no matter the aspect ratio. Anything with the rotation set to 90 deg creates the exact same bug.

@iiiGerardoiii
Copy link

iiiGerardoiii commented Dec 13, 2021

I've had this issue occasionally and it's always vertical videos that were shot from a smartphone and imported directly from the phone (not downloaded from youtube or a website that compresses or modifies the video during upload).

I remember having a similar problem when using Kodi on my Raspberry Pi, if I hit play on any vertical video it looked all glitched (the actual video, not the thumbnails), audio was fine though.

Here's a sample that generates glitched thumbnails on my end, @marzzzello can you try this file:

vertical.thumb.glitched.test.mp4

how it looks here:
mpv_PCgu8XWaZe

@marzzzello
Copy link
Owner

marzzzello commented Jan 1, 2022

Screenshot from 2022-01-01 12-08-06
@iiiGerardoiii That's how your video looks for me.
What OS and mpv version are you using? Any modifications or config changes?
I use mpv 1:0.34.0-3 on Arch, tested with mpv_thumbnail_script 0.4.4 and 0.4.5
My configs: conf.zip

@marzzzello marzzzello added the bug Something isn't working label Jan 1, 2022
@marzzzello marzzzello added the cannot reproduce This issue is not reproducible with the information provided label Mar 21, 2022
@iiiGerardoiii
Copy link

Interesting, sometimes it shows the stretched thumbnail, and sometimes it glitches.

Try to play the actual video link without downloading it maybe:

.\mpv.com https://user-images.githubusercontent.com/6264194/145737907-3fb3c8e5-e510-4641-8631-72c1b725ecb1.mp4

po5 added a commit to po5/thumbfast that referenced this issue Sep 18, 2022
po5 added a commit to po5/mpv_thumbnail_script that referenced this issue May 3, 2023
@po5 po5 linked a pull request May 3, 2023 that will close this issue
@NicolaSmaniotto NicolaSmaniotto removed the cannot reproduce This issue is not reproducible with the information provided label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants