From ed3365e5b3896777e556e90d98097def1c7afe47 Mon Sep 17 00:00:00 2001 From: Noah Lev Date: Tue, 6 Aug 2024 13:17:04 -0700 Subject: [PATCH] Disable linkcheck in PRs until bugs are fixed See https://github.com/Michael-F-Bryan/mdbook-linkcheck/issues/77 and https://github.com/Michael-F-Bryan/mdbook-linkcheck/issues/86. These bugs are causing linkcheck to erroneously fail because we run it using `-f`, to avoid too many requests. For now, disable linkcheck in PR CI, though leave it enabled in the cron job, where the bug should not occur. --- ci/linkcheck.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ci/linkcheck.sh b/ci/linkcheck.sh index 14cd53ac9..5f523f874 100755 --- a/ci/linkcheck.sh +++ b/ci/linkcheck.sh @@ -14,6 +14,9 @@ if [ "$GITHUB_EVENT_NAME" = "schedule" ] ; then # running in scheduled job echo "Doing full link check." elif [ "$GITHUB_EVENT_NAME" = "pull_request" ] ; then # running in PR CI build + echo "*** WARNING: linkcheck temporarily disabled due to bugs ***" + exit 0 + if [ -z "$BASE_SHA" ]; then echo "error: unexpected state: BASE_SHA must be non-empty in CI" exit 1 @@ -25,6 +28,9 @@ elif [ "$GITHUB_EVENT_NAME" = "pull_request" ] ; then # running in PR CI build echo "Checking files changed since $BASE_SHA: $CHANGED_FILES" else # running locally + echo "*** WARNING: linkcheck temporarily disabled due to bugs ***" + exit 0 + COMMIT_RANGE=master... CHANGED_FILES=$(git diff --name-only $COMMIT_RANGE | sed 's#^src/##' | tr '\n' ' ') FLAGS="-f $CHANGED_FILES"