Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add CuteBoard #2103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Van020530
Copy link
Contributor

Real time Dashboard (Qt)

log: add software

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

+dekstop.files = app/CuteBoard.desktop
+desktop.path = $$DATADIR/applications/
+icon.files = app/resources/logo/cuteboard.png
+icon.path= $$DATADIR/icons/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons路径

Real time Dashboard (Qt)

log: add software
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-fix.patch文件中,注释掉的代码被删除,可能会影响代码的功能。
  • CuteBoard.pro文件中,desktop.filesicon.files变量被添加,但未看到对应的INSTALLS指令来安装这些文件。
  • DemoDataSource/demoparameter.cpp文件中,DataValue类型的返回值从int64_t更改为quint64,需要确认这是否符合设计需求。

是否建议立即修改:

  • 是,需要确认这些更改是否符合项目需求,并确保代码的功能和一致性。同时,建议添加必要的注释来解释这些更改的原因和影响。

@Van020530
Copy link
Contributor Author

/check build

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 29, 2024

Deepin Obs Bot
Starting find obs webhook event and retrigger!

@kamiyadm
Copy link
Contributor

patch失败了

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants