Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the app 100% Redux #353

Open
2 of 3 tasks
martpie opened this issue Jul 27, 2017 · 8 comments
Open
2 of 3 tasks

Make the app 100% Redux #353

martpie opened this issue Jul 27, 2017 · 8 comments
Assignees

Comments

@martpie
Copy link
Owner

martpie commented Jul 27, 2017

We currently use an hybrid between Vanilla Flux and Redux for state management, and we have problems passing a huge number of props through all the children components. I would like we move everything to a more Redux way, especially about the dispatch thing.

  • Dispatches, the Redux way?
  • "real" Presentational and Container Components with connect and mapStateToProps
  • Initial state in reducers

http://redux.js.org/docs/basics/UsageWithReact.html#presentational-and-container-components
http://redux.js.org/docs/advanced/UsageWithReactRouter.html

@martpie martpie self-assigned this Jul 27, 2017
@YurySolovyov
Copy link
Collaborator

YurySolovyov commented Jul 27, 2017

I'd add:

  • Make store shape map to reducers so we can use combineReducers

@martpie
Copy link
Owner Author

martpie commented Dec 5, 2017

poke #370

@YurySolovyov
Copy link
Collaborator

@martpie
Copy link
Owner Author

martpie commented Dec 8, 2017

So apparently it's not, I've seen some stuff from Dan Abramov where he says it is perfectly fine

https://stackoverflow.com/questions/35667249/accessing-redux-state-in-an-action-creator#35674575

@YurySolovyov
Copy link
Collaborator

Why player is in state anyway?

@martpie
Copy link
Owner Author

martpie commented Dec 8, 2017

I think you are mixing up the Player lib and the Player reducer

@YurySolovyov
Copy link
Collaborator

Could be worthwhile: https://github.com/rematch/rematch

@martpie
Copy link
Owner Author

martpie commented Mar 2, 2018

Looks great, I will give it a try!

@martpie martpie added this to the 0.10 milestone Apr 3, 2018
@martpie martpie removed this from the 0.10 milestone Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants