Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to HTML templates for constructing page components #32

Open
martindholmes opened this issue Apr 23, 2021 · 1 comment
Open

Switch to HTML templates for constructing page components #32

martindholmes opened this issue Apr 23, 2021 · 1 comment

Comments

@martindholmes
Copy link
Owner

The original methods by which the vector layer constructs page components such as menus was written before HTML templates were widely supported; it would probably be faster and more easily maintainable to have those functions use template elements built into the HTML in the template page itself.

@martindholmes martindholmes added this to the Release 1.1 milestone Apr 23, 2021
@martindholmes martindholmes self-assigned this Apr 23, 2021
@martindholmes
Copy link
Owner Author

martindholmes commented May 24, 2024

Initial work on this is happening in the issue-32-templates branch. It's complicated by the fact that we don't actually control the host page HTML, so it may not even be practical. There seems little point in creating templates in JS at runtime, then using them; might as well create the elements themselves. However, there might be some way to inject the templates into existing HTML at build time, and then use them. That would involve processing the host page, though, and we don't currently do that except in the test projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant