Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minified javascript in source tree #7

Open
onlyjob opened this issue Jul 1, 2015 · 1 comment
Open

minified javascript in source tree #7

onlyjob opened this issue Jul 1, 2015 · 1 comment

Comments

@onlyjob
Copy link

onlyjob commented Jul 1, 2015

Minified javascripts are effectively the same as pre-compiled binaries --
un-readable, non-modifiable and non-distributable in Debian.
It is the best to have no minified files in source tree at all.

Please consider removing minified file assets/javascripts/codemirror.min.js.

Removing this file requires the following patch:

--- a/app/views/settings/_custom_css.html.erb
+++ b/app/views/settings/_custom_css.html.erb
@@ -1,6 +1,6 @@
 <%= stylesheet_link_tag 'codemirror', :plugin => :redmine_custom_css %>
-<%= javascript_include_tag 'codemirror.min', :plugin => :redmine_custom_css %>
+<%= javascript_include_tag 'codemirror', :plugin => :redmine_custom_css %>

 <style type="text/css">
     .CodeMirror {
         height: auto;

Thanks.

@martin-denizet
Copy link
Owner

Out of curiosity. Would specifying a "SourceMap" solve elegantly the problem?
Explanations about Source Maps: http://blog.teamtreehouse.com/introduction-source-maps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants