From cb0c9d2fdefaa50eb294a6a0999d5ab3f0b83271 Mon Sep 17 00:00:00 2001 From: Mars Hall Date: Sun, 10 Mar 2019 09:22:37 -0700 Subject: [PATCH] Deploy with auto build (#17) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove `npm run build` step, since the Node buildpack now runs it automatically, https://devcenter.heroku.com/changelog-items/1557 * 📚 clarify how this project fits into React deployment --- README.md | 2 +- bin/compile | 14 -------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/README.md b/README.md index 77265cf..d345b2b 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ Inner layer of Heroku Buildpack for create-react-app ==================================================== -See: [create-react-app-buildpack](https://github.com/mars/create-react-app-buildpack) +See: [create-react-app-buildpack's architecture](https://github.com/mars/create-react-app-buildpack/blob/master/README.md#user-content-architecture-) for how this helps deploy React apps. [![Build Status](https://travis-ci.org/mars/create-react-app-inner-buildpack.svg?branch=master)](https://travis-ci.org/mars/create-react-app-inner-buildpack) diff --git a/bin/compile b/bin/compile index ed4a41e..776688b 100755 --- a/bin/compile +++ b/bin/compile @@ -55,17 +55,3 @@ cp "$BP_DIR/lib/injectable_env.rb" "$cra_dir/" profile_d_dir="$BUILD_DIR/.profile.d" mkdir -p "$profile_d_dir" cp "$BP_DIR/.profile.d/inject_react_app_env.sh" "$profile_d_dir/" - -# Support env vars during build: -# * `REACT_APP_*` -# * https://github.com/facebookincubator/create-react-app/blob/v0.2.3/template/README.md#adding-custom-environment-variables -# * `NODE_*`, especially for `NODE_PATH` -# * https://github.com/facebookincubator/create-react-app/pull/476 -# * `NPM_*`, especially for `NPM_TOKEN` -# * https://docs.npmjs.com/private-modules/ci-server-config -# * `HEROKU_*`, especially for Dyno Metadata -# * https://devcenter.heroku.com/articles/dyno-metadata -export_env_dir "$ENV_DIR" '^(REACT_APP_|NODE_|NPM_|HEROKU_)' - -# Build the javascript bundle -npm run build