Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error admin-on-rest > react-router-dom > react@^15" doesn't satisfy found match of "[email protected]" #1566

Closed
FDiskas opened this issue Feb 18, 2018 · 5 comments

Comments

@FDiskas
Copy link

FDiskas commented Feb 18, 2018

admin-on-rest: v1.4.0
react: 16.2.0
yarn check

@fzaninotto
Copy link
Member

I think that means we should upgrade react-router in master.

But you'll have other warnings with react 16.2. Normally, it's a peer dependency so it should not cause any harm other than these warnings.

@FDiskas
Copy link
Author

FDiskas commented Feb 19, 2018

I think that react-router-dom should be used and react-router is an dependency of that
https://github.com/ReactTraining/react-router/blob/ecc9a73230f574cba138929cd8ef829592609006/packages/react-router-dom/package.json#L47
🏁

@Adebeer
Copy link

Adebeer commented Mar 12, 2018

It'll be nice to remove these warnings - I normally pin these errors down by doing a npm list --depth=2
From what I can see, the react@^15 warnings are coming indirectly from [email protected] - which still references react 15 dependencies.

I'm getting the following peer dep warnings:
npm ERR! peer dep missing: react@^15, required by [email protected]
npm ERR! peer dep missing: react@^15, required by [email protected]
npm ERR! peer dep missing: react@^15, required by [email protected]

@mhyassin
Copy link

If we update to react-router-dom 4.2.2 it'll fix the dependencies warnings

@fzaninotto
Copy link
Member

Moved to marmelab/admin-on-rest#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants