Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error in development mode if a page is served without a <head> and <body> #6

Open
mlrawlings opened this issue Jun 9, 2017 · 0 comments

Comments

@mlrawlings
Copy link
Contributor

mlrawlings commented Jun 9, 2017

marko-starter injects stylesheets and scripts at the end of the <head> and <body> tags. If they're not there, the page doesn't have styling or functionality.

I imaging this could be confusing if you created a page that just had

<h1>Hello world</h1>
<counter/>

and your counter just wasn't working.

I'm thinking we may need to monkeypatch response.end to do this, but it would only be in development mode. Is there a better way we could display this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant