Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying the column used to join to the document to retrieve geometries #61

Open
jkerr5 opened this issue Apr 30, 2020 · 1 comment

Comments

@jkerr5
Copy link
Collaborator

jkerr5 commented Apr 30, 2020

Right now, the column name used to join the document into the optic pipeline is hardcoded to DocId and this will come from the first view in the data sources array.

We need to make this configurable by requiring the column name to be specified in the geometry.source object in the layer descriptor. The new property should be called joinDocColumn and must be present if the geometry will be extracted via XPath (the xpath property is also present).

The code should then use that property when joining in the document such that the geometry can be extracted: https://github.com/marklogic-community/marklogic-geo-data-services/blob/master/src/main/ml-modules/services/geoQueryService.sjs#L1017

If the joinDocColumn is not present but the document is needed to extract the geometry, the fragment ID column from the "primary" data source (the first in the array) will be used.

The column that the document content is stored in is called doc. Perhaps this should be renamed to geometryDoc to make it more explicit and also reduce the changes of a collision with the name.

@jkerr5
Copy link
Collaborator Author

jkerr5 commented Jan 3, 2023

We need to relook at this to see if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant