If the slider only contains one slide, it will generate an error

[abstractic]

If the slider only contains one slide, it will generate an error, please see line 23 and the row:

this._originalFlexsliderWrapupFunction = this._flexslider.wrapup;

[syncnet]

If you only have one slide then you shouldn't be using a slider in the first place. Just place your image and you are done!

[markirby]

Yes! Indeed!

Mark

On 25 Jan 2013, at 22:07, syncnet [email protected] wrote:

If you only have one slide then you shouldn't be using a slider in the first place. Just place your image and you are done!

—
Reply to this email directly or view it on GitHub.

[abstractic]

Well, I can't control how many slides my customers choose to use, so in the case where they only use one slide, the slider generates an error. I think it's lame, to not control what happens if you remove all slides except one, so that's it.

[abstractic]

For your information. You only need to check that the flexslider not are undefined, before you initialize it. A simple solution could be:

if (this._flexslider != undefined) {

this._originalFlexsliderWrapupFunction = this._flexslider.wrapup;
this._defaults = defaults;
this._name = flexsliderManualDirectionControls;
this.init();

}


[markirby]

Thanks, although I think you shouldn't need to use this anymore, since the update to FlexSlider which allows manual controls to be used.

Cheers,

Mark

On 28 Jan 2013, at 12:26, Richard Persson [email protected] wrote:

For your information. You only need to check that the flexslider not are undefined, before you initialize it. A simple solution could be:

function FlexsliderManualDirectionControls( element, options ) {
this.element = element;
this.options = $.extend( {}, defaults, options) ;
this._flexslider = $(element).data('flexslider');

if (this._flexslider != undefined) {

this._originalFlexsliderWrapupFunction = this._flexslider.wrapup;
this._defaults = defaults;
this._name = flexsliderManualDirectionControls;

this.init();

}
}

—
Reply to this email directly or view it on GitHub.

[abstractic]

There are still not any support for custom controls in the new FlexSlider, so your code is still, very useful for those who like to move the controls out from the slider element.

Cheers,
Ricki

[markirby]

Oh - interesting, I was mistaken. Glad it was worth the effort then!

On 28 Jan 2013, at 12:35, Richard Persson [email protected] wrote:

There are still not any support for custom controls in the new FlexSlider, so your code is still, very useful for those who like to move the controls out from the slider element.

Cheers,
Ricki

—
Reply to this email directly or view it on GitHub.

[mgratch]

Currently you can change the controlNav but not the directionNav.

@abstractic agreed.

[CHEWX]

Yup, another +1 for the code. No idea why you cannot customise directionNav but you can controlNav - very dis-jointed.