-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Sort, Search and Filter in timeline view #1
Comments
The views are really only designed to display what is given to them, already sorted/filtered. What the web app and vs code extension do is Is this the right way? I don't know. I like the strict separation but a case could be made that it's separated at the wrong point. You could make a simple iframe that hosts the timeline (or other views, for that matter; they all speak the same language) and adds some of that functionality back by sending messages for sorted and filtered views. The views display whatever is in the It might be easier to do this inside the timeline view and other people might be interested in it too 🤷 |
Thanks @kochrt for the explanation for this. I have a specific use case where the static html that doesn't require any links works very well. I was hoping we could keep the static html and add the filtering but I guess not. Edit: just for fun, I tried exploring the postMessage to the iframe solution. Here is the quick and dirty approach:
where transformedMw holds the full transformed json from the output of the CLI, with a tiny change on the first event. |
We're source controlling some mw files and we have a pipeline use If the CLI could optionally include sort/search/filter in the stand alone html that would be super helpful. We don't really need a full website, the goal is interactive data visualization. |
First of all, great to have this CLI to generate static html from markwhen.
I have been tinkering with it for a while but cannot find a way to integrate the Sort, Search and Filter functionalities that are available on the markwhen web app.
I have found them in the markwhen/markwhen repo (ex sort: https://github.com/mark-when/markwhen/blob/25779d9238477ec76eb988a0c6a0af754fdf624e/src/Drawer/ViewSettings/Sort.vue) but don't find them on the individual markwhen/timeline repo.
The text was updated successfully, but these errors were encountered: