Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/clean up net projects #176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/clean up net projects #176

wants to merge 2 commits into from

Conversation

Apollo3zehn
Copy link

changes:

  • replace .NET Standard, .NET, .NET Core and PCL projects with: .NET Standard 1.0, .NET Standard 1.3 and .NET 2.0 combined in a single project via <TargetFrameworks>netstandard1.0;netstandard1.3;net20</TargetFrameworks>
  • Adapt the #if NETSTANDARD directives
  • Adapt the nuspec file to reflect the new list of projects
  • Remove
    #if PCL
    Console.WriteLine(mXparser.getConsoleOutput());
    #endif
    because the PCL project does not exist anymore
  • Update Test projects to NET 4.7.2 since that is the first version that fully supports .NET Standard 2.0 (not so important change :-) )
  • Remove obsolete test projects

The following table gives a rough overview about the framework dependencies and why (in my opinion) only three target frameworks are required:

Framework Compatible to
net20 to net40 net20
net45 to net472 netstandard10
net46 to net48 netstandard13
netcoreapp10 to netcoreapp11 netstandard10
netcoreapp20 to netcoreapp30 netstandard13
PLC netstandard10 / netstandard13

@mariuszgromada:

  • What is the purpose of the mXparser-00-Current project? Is it for testing?
  • I am not sure how you generate the nuget package. I was able to compile the project and then tried to generate a package via dotnet pack but I got the error that I have no .NET 2.0 installed, though I have it. I hope you can generate the package successfully (since compilation is successful).

@mariuszgromada
Copy link
Owner

Thank you!! I am going to verify and merge :-)

mXparser-00 is a project where i make development and all the testing (changing properties etc.)

Nuget package is generated by nuget explorer - a kind of visual tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants