-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default remappings_version to false #176
Comments
Similarly why not make recursive_deps default to true and remappings_regenerate default to true? IMO defaults should cover the average/basic case, and custom configs for power users who want more complex behavior. I feel that auto-generating simple mappings is the most likely case |
The next version (0.4.0) will default to include a version requirements string in the remapping name, as opposed to an exact version. As such, you will be able to specify To expand on this, it's important to include some kind of version info in the remapped path so that if one of your dependencies uses a different major version (e.g. openzeppelin contracts v4.x), both package versions can co-exist and use a different import path to avoid resolution conflicts. For Regarding the recursive install, I think we might consider a change in defaults once we are sure it matches the use-case of everyone and there are no major drawbacks to using it. |
Hey @marktoda , is my answer satisfactory or do you still think the default should change? Please also check this section of the new usage guide for an explanation. |
IMO the remappings version should be defaulted to false. It's quite annoying to have to update every import location on upgrading version, and benefit is unclear to me
The text was updated successfully, but these errors were encountered: