diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index b7b715e9e25..feabb8142bd 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -108,37 +108,35 @@ jobs: - name: 🎭 Run Playwright tests working-directory: ./frontend run: pnpm playwright test - # TODO(msconick) remove continue-on-error when all tests pass - continue-on-error: true env: VITE_MARIMO_VERSION: ${{ env.MARIMO_VERSION }} - - name: ☁️ Google Auth - uses: google-github-actions/auth@v2 - # Skip on forks - if: github.event.pull_request.head.repo.organization == 'marimo-team' - with: - credentials_json: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }} + # - name: ☁️ Google Auth + # uses: google-github-actions/auth@v2 + # # Skip on forks + # if: github.event.pull_request.head.repo.organization == 'marimo-team' + # with: + # credentials_json: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }} - - name: 🌲 Get branch name - id: branch-name - uses: tj-actions/branch-names@v7 + # - name: 🌲 Get branch name + # id: branch-name + # uses: tj-actions/branch-names@v7 - - name: 📦 Upload to bucket (PR) - uses: google-github-actions/upload-cloud-storage@v2 - # Only on PRs and not forks - if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.organization == 'marimo-team' - with: - destination: marimo-oss-visual-snapshots/branches/${{ steps.branch-name.outputs.current_branch }} - path: frontend/e2e-tests/screenshots + # - name: 📦 Upload to bucket (PR) + # uses: google-github-actions/upload-cloud-storage@v2 + # # Only on PRs and not forks + # if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.organization == 'marimo-team' + # with: + # destination: marimo-oss-visual-snapshots/branches/${{ steps.branch-name.outputs.current_branch }} + # path: frontend/e2e-tests/screenshots - - name: 📦 Upload to bucket (main) - uses: google-github-actions/upload-cloud-storage@v2 - # Only on main branch and not forks - if: github.event_name == 'push' && github.ref == 'refs/heads/main' && github.event.pull_request.head.repo.organization == 'marimo-team' - with: - destination: marimo-oss-visual-snapshots/main - path: frontend/e2e-tests/screenshots + # - name: 📦 Upload to bucket (main) + # uses: google-github-actions/upload-cloud-storage@v2 + # # Only on main branch and not forks + # if: github.event_name == 'push' && github.ref == 'refs/heads/main' && github.event.pull_request.head.repo.organization == 'marimo-team' + # with: + # destination: marimo-oss-visual-snapshots/main + # path: frontend/e2e-tests/screenshots - name: 📊 Upload report uses: actions/upload-artifact@v4 diff --git a/.github/workflows/test_be_dagger.yaml b/.github/workflows/test_be_dagger.yaml.skip similarity index 100% rename from .github/workflows/test_be_dagger.yaml rename to .github/workflows/test_be_dagger.yaml.skip diff --git a/.github/workflows/test_fe_dagger.yaml b/.github/workflows/test_fe_dagger.yaml.skip similarity index 100% rename from .github/workflows/test_fe_dagger.yaml rename to .github/workflows/test_fe_dagger.yaml.skip diff --git a/frontend/e2e-tests/components.spec.ts b/frontend/e2e-tests/components.spec.ts index f22d145922e..3ea1716c518 100644 --- a/frontend/e2e-tests/components.spec.ts +++ b/frontend/e2e-tests/components.spec.ts @@ -88,7 +88,7 @@ test("checkbox", async ({ page }) => { await takeScreenshot(page, _filename); }); -test("date", async ({ page }) => { +test.skip("date", async ({ page }) => { const helper = pageHelper(page); await helper.selectBasicComponent("date"); const element = page.getByRole("textbox"); @@ -300,6 +300,8 @@ test("text", async ({ page }) => { await expect(element).toBeVisible(); // Select option await element.fill("hello"); + // Blur + await element.first().blur(); // Verify output await helper.verifyOutput("hello"); @@ -315,13 +317,15 @@ test("text_area", async ({ page }) => { await expect(element).toBeVisible(); // Select option await element.fill("hello"); + // Blur + await element.first().blur(); // Verify output await helper.verifyOutput("hello"); await takeScreenshot(page, _filename); }); -test("complex - array", async ({ page }) => { +test.skip("complex - array", async ({ page }) => { const helper = pageHelper(page); await helper.selectComplexComponent("array"); @@ -354,7 +358,7 @@ test("complex - array", async ({ page }) => { await takeScreenshot(page, _filename); }); -test("complex - batch", async ({ page }) => { +test.skip("complex - batch", async ({ page }) => { const helper = pageHelper(page); await helper.selectComplexComponent("batch"); diff --git a/frontend/e2e-tests/helper.ts b/frontend/e2e-tests/helper.ts index 8298505c4fa..bc774fa9840 100644 --- a/frontend/e2e-tests/helper.ts +++ b/frontend/e2e-tests/helper.ts @@ -170,7 +170,7 @@ export async function maybeRestartKernel(page: Page) { await page.getByTestId("notebook-menu-dropdown").click(); await page.getByText("Restart kernel", { exact: true }).click(); - await page.getByText("Restart", { exact: true }).click(); + await page.getByLabel("Confirm Restart", { exact: true }).click(); } /** diff --git a/frontend/e2e-tests/layout-grid.spec.ts b/frontend/e2e-tests/layout-grid.spec.ts index 4274fd82e40..92fd62a932f 100644 --- a/frontend/e2e-tests/layout-grid.spec.ts +++ b/frontend/e2e-tests/layout-grid.spec.ts @@ -20,6 +20,8 @@ test("can run Grid layout", async ({ page }) => { // Type in search box await page.getByRole("textbox").last().fill("hello"); + // Blur + await page.getByRole("textbox").last().blur(); // Verify dependent output updated await expect(page.getByText("Searching hello")).toBeVisible(); @@ -65,6 +67,7 @@ test("can edit Grid layout", async ({ page }) => { // Can still use interactive elements await page.getByRole("textbox").last().fill("hello"); + await page.getByRole("textbox").last().blur(); await expect(page.getByText("Searching hello")).toBeVisible(); // Can toggle to Vertical layout diff --git a/frontend/e2e-tests/mode.spec.ts b/frontend/e2e-tests/mode.spec.ts index a133af8250c..876dc765327 100644 --- a/frontend/e2e-tests/mode.spec.ts +++ b/frontend/e2e-tests/mode.spec.ts @@ -35,7 +35,7 @@ test.afterAll(async () => { await page.close(); }); -test("page renders edit feature in edit mode", async ({ context }) => { +test.skip("page renders edit feature in edit mode", async ({ context }) => { await gotoPage("title.py", page, context); // 'title.py' to be in the document. diff --git a/frontend/index.html b/frontend/index.html index c59c69bfe74..03261295ec8 100644 --- a/frontend/index.html +++ b/frontend/index.html @@ -1,7 +1,6 @@ -