Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Terminal does not use --marimo-monospace-font (or any other css var from custom.css) #2982

Open
susl opened this issue Nov 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@susl
Copy link

susl commented Nov 26, 2024

Describe the bug

I wanted to open a terminal in Marimo, but my prompt was messed up, because I'm using nerd font and xterm in marimo could not render in properly.

I tried configuring --marimo-monospace-font as the documentation says it's the font used for code blocks, so I assume terminal would use it as well. But it does not, an it appears that there's no proper way to configure it.

For now, I did this in custom.css, but it's hacky:

@import url("https://mshaugh.github.io/nerdfont-webfonts/build/firacode-nerd-font.css");
.xterm-rows {
    font-family: "FiraCode Nerd Font", monospace !important;
}

Environment

{
"marimo": "0.9.26",
"OS": "Darwin",
"OS Version": "24.1.0",
"Processor": "i386",
"Python Version": "3.13.0",
"Binaries": {
"Browser": "131.0.6778.86",
"Node": "v23.3.0"
},
"Dependencies": {
"click": "8.1.7",
"docutils": "0.21.2",
"itsdangerous": "2.2.0",
"jedi": "0.19.2",
"markdown": "3.7",
"narwhals": "1.14.2",
"packaging": "24.2",
"psutil": "6.1.0",
"pygments": "2.18.0",
"pymdown-extensions": "10.12",
"pyyaml": "6.0.2",
"ruff": "0.8.0",
"starlette": "0.41.3",
"tomlkit": "0.13.2",
"typing-extensions": "missing",
"uvicorn": "0.32.1",
"websockets": "14.1"
},
"Optional Dependencies": {}
}

Code to reproduce

app = marimo.App(width="medium", css_file="custom.css")

and

@import url("https://mshaugh.github.io/nerdfont-webfonts/build/firacode-nerd-font.css");
:root {
    font-family: "FiraCode Nerd Font", monospace !important;
}
@susl susl added the bug Something isn't working label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant