Form with examples #2979
Merged
Form with examples #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
approved these changes
Nov 26, 2024
|
@mscolnick the link got reformatted to |
4 tasks
mscolnick
pushed a commit
that referenced
this pull request
Nov 26, 2024
## 📝 Summary #2979 (comment) After checking the updated website, noticed that the query parameter in the link to notebook got reformatted to `https://marimo.app/l/w21a3x?t1=query&t2=params` - which breaks the notebook. ## 🔍 Description of Changes try HTML instead of Markdown link ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. ## 📜 Reviewers @mscolnick
Light2Dark
pushed a commit
to Light2Dark/marimo
that referenced
this pull request
Nov 27, 2024
## 📝 Summary Provides recipes for pre-populating forms from examples or query parameters ## 🔍 Description of Changes [New form recipe](https://marimo.app/l/w21a3x?t1=query&t2=params) Less hacky marimo-team#2928 :) ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected.
Light2Dark
pushed a commit
to Light2Dark/marimo
that referenced
this pull request
Nov 27, 2024
## 📝 Summary marimo-team#2979 (comment) After checking the updated website, noticed that the query parameter in the link to notebook got reformatted to `https://marimo.app/l/w21a3x?t1=query&t2=params` - which breaks the notebook. ## 🔍 Description of Changes try HTML instead of Markdown link ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. ## 📜 Reviewers @mscolnick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Provides recipes for pre-populating forms from examples or query parameters
🔍 Description of Changes
New form recipe
Less hacky #2928 :)
📋 Checklist