Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit card validation #12

Open
marcwrobel opened this issue May 29, 2014 · 5 comments
Open

Credit card validation #12

marcwrobel opened this issue May 29, 2014 · 5 comments

Comments

@marcwrobel
Copy link
Owner

Add credit card validation support.

@marcwrobel
Copy link
Owner Author

marcwrobel commented May 29, 2014

See https://howtodoinjava.com/regex/java-regex-validate-credit-card-numbers/ for some details on how to validate credit cards.

@jycr
Copy link

jycr commented Apr 28, 2020

It would be better to include this feature in another library.
In a pure SEPA processing platform, we does not need to deal with Credit Card number.

@marcwrobel
Copy link
Owner Author

@jycr, thank you for your feedback.

JBanking is meant to address general banking concerns, it is not only a library for SEPA. So I still think this feature can have its place in this library.

@jycr
Copy link

jycr commented Apr 30, 2020

If you add an other functionnal domain (for example: "credit card"), have you planned to split this new domain into dedicated Maven module?
It would be great because we can import only needed modules in our application.

Indeed, we place great importance on minimizing the attack surface in our applications.

@marcwrobel
Copy link
Owner Author

marcwrobel commented May 10, 2020

@jycr, I do not plan to split jbanking in multiple modules for the time being because the library is still very small.

Fyi I planned to work mainly on #34 for the next few releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants