Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Crashes After Close #1

Open
ghost opened this issue May 23, 2016 · 2 comments
Open

Editor Crashes After Close #1

ghost opened this issue May 23, 2016 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented May 23, 2016

Hey! Thanks for this project first of all, it's a life savior!

When you preview your project and successfully connect to your websocket server, then close your app, this message pops up:

https://i.gyazo.com/2768e8034e23b31baac72ffb187aab2c.gif

But, when you remove the thread.start(self,'_run', self) line, this error goes away (but you are not connected :P) Any idea why that is? Just curious, thanks!

@marcosbitetti
Copy link
Owner

This line make socket to works.
This error from windows is a generic message. Not show nothing.
This is probably is a platform specific error, because thread not stop on window close, and reference that not destroyed by Godot core.
The soluction is possible to try handle the onclose, event... maybe.
I intend to work more on it at weekend. Includint to suport messages biggest to 126 characteres.
For now, it it not cause connections issues, can be waiting for more polish work.

@ghost
Copy link
Author

ghost commented May 24, 2016

@marcosbitetti Thanks for the response. I'm new to gdscript, so learning a lot as I go, thank you for keeping it updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant