From db819c56e8c139fb01c18045438c5b80e799359a Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Fri, 6 Sep 2024 09:18:44 +0000 Subject: [PATCH] Bug 1912230 - shorten messaging to avoid truncation. r=android-reviewers,mcarare The fullscreen messaging was getting slightly truncated after translation into some other languages, so the message has been expressed here in a slightly more concise way. Differential Revision: https://phabricator.services.mozilla.com/D221123 UltraBlame original commit: cbfd8f13ada7739ef07dd4873cfd87e69e5c91d2 --- .../fenix/browser/BaseBrowserFragment.kt | 4 +- .../fenix/app/src/main/res/values/strings.xml | 159 ++++++++++++++++++ 2 files changed, 161 insertions(+), 2 deletions(-) diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt index a90111960134..3e9f7ed46cc8 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt @@ -12349,7 +12349,7 @@ R . string . -exit_fullscreen_with_gesture +exit_fullscreen_with_gesture_short ) backButtonString = @@ -12359,7 +12359,7 @@ R . string . -exit_fullscreen_with_back_button +exit_fullscreen_with_back_button_short ) GestureNavUtils ) diff --git a/mobile/android/fenix/app/src/main/res/values/strings.xml b/mobile/android/fenix/app/src/main/res/values/strings.xml index 3e79a03b1bae..56f33cbf5688 100644 --- a/mobile/android/fenix/app/src/main/res/values/strings.xml +++ b/mobile/android/fenix/app/src/main/res/values/strings.xml @@ -49486,6 +49486,20 @@ name " exit_fullscreen_with_gesture " +moz +: +removedIn += +" +132 +" +tools +: +ignore += +" +UnusedResources +" > To exit @@ -49529,6 +49543,20 @@ name " exit_fullscreen_with_back_button " +moz +: +removedIn += +" +132 +" +tools +: +ignore += +" +UnusedResources +" > To exit @@ -49547,6 +49575,137 @@ string ! - - +Message +shown +to +explain +how +to +exit +fullscreen +mode +when +gesture +navigation +is +enabled +. +- +- +> +< +! +- +- +Localisation +note +: +this +text +should +be +as +short +as +possible +max +68 +chars +- +- +> +< +string +name += +" +exit_fullscreen_with_gesture_short +" +> +Drag +from +top +& +amp +; +use +back +gesture +to +exit +< +/ +string +> +< +! +- +- +Message +shown +to +explain +how +to +exit +fullscreen +mode +when +using +back +button +navigation +. +- +- +> +< +! +- +- +Localisation +note +: +this +text +should +be +as +short +as +possible +max +68 +chars +- +- +> +< +string +name += +" +exit_fullscreen_with_back_button_short +" +> +Drag +from +top +& +amp +; +press +back +to +exit +< +/ +string +> +< +! +- +- Beta Label Component