Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yanked release and version comparison links slightly wrong #14

Open
marcaddeo opened this issue Jul 10, 2020 · 1 comment
Open

Yanked release and version comparison links slightly wrong #14

marcaddeo opened this issue Jul 10, 2020 · 1 comment

Comments

@marcaddeo
Copy link
Owner

When you yank a release the next release is still using it in it's comparison link.. This is probably not ideal.

For example:

## [5.10.1] - 2020-01-02

## 5.10.0 - 2020-01-02 [YANKED]

## [5.9.5] - 2019-12-22

[5.10.1]: https://github.com/my/repo/compare/5.10.0...5.10.1

I think ideally this would go back to the previous release that is not yanked.

## [5.10.1] - 2020-01-02

## 5.10.0 - 2020-01-02 [YANKED]

## [5.9.5] - 2019-12-22

[5.10.1]: https://github.com/my/repo/compare/5.9.5...5.10.1
@marcaddeo
Copy link
Owner Author

marcaddeo commented Oct 25, 2023

Looked into this a tad more. Making this behave better would likely best be implemented in Release::yank() so that when you yank a release, it fixes the associated links as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant