Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop funktion does not work #4

Open
dvovla opened this issue Oct 2, 2021 · 10 comments
Open

Stop funktion does not work #4

dvovla opened this issue Oct 2, 2021 · 10 comments

Comments

@dvovla
Copy link

dvovla commented Oct 2, 2021

No description provided.

@MKaiser96
Copy link

I agree with you. I had to go back to version 1.4.1. This version works fine.

@pow4all
Copy link

pow4all commented Oct 11, 2021

Same here, stop function is not working in 1.4.2

Edit: I figured it out. If you send a payload of 0 or false and the topic 'control' it isn't working. If you send the payload of 0 or false without a topic it is working. Good to know.

@jeffreychausse
Copy link

jeffreychausse commented Oct 23, 2021

Same here! Workaround proposed by @pow4all does not seem to work either.

I don't believe it is related to this issue, but I noticed a typo error at line 101.

var remainingTicksMsg = { "payload": ticks, "cancled": cancel };

I guess you meant canceled instead of cancled.

@wedlock
Copy link

wedlock commented Nov 16, 2021

Stop function in node red dont work.

@bierre2000
Copy link

I confirm it's not working neither here.
Even with the given exemple on the node page, timer won't stop.

@pal2110
Copy link

pal2110 commented Dec 12, 2021

Got hit with the same problem. Quick skim through the code and it appears a msg.topic: control, and a msg.payload: cancel will get the timer to stop.

@zsiti
Copy link

zsiti commented Jun 11, 2022

Got hit with the same problem. Quick skim through the code and it appears a msg.topic: control, and a msg.payload: cancel will get the timer to stop.

Indeed, "cancelling" the timer might be a functional workaround for some use-cases, but actually there is a difference between "stopping" and "cancelling" the timer.

The "stopping" function stops the timer and emits a "Timer Off" payload (if configured on the node) on the first output of the node, while the "cancel" function just stops the timer without emitting any output.

As @MKaiser96 has stated in this thread above: if you downgrade from 1.4.2 to 1.4.1, the stopping function will work as intended.

@linker3000
Copy link

Any chance of this being fixed in the release version?

@frankverheyen
Copy link

When is this problem going to be fixed!!!! I am using this countdown node very much!

@Graefer
Copy link

Graefer commented Aug 2, 2023

Not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests