Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relative paths from run_test_suite.sh #472

Open
mnlevy1981 opened this issue Oct 3, 2024 · 0 comments
Open

Remove relative paths from run_test_suite.sh #472

mnlevy1981 opened this issue Oct 3, 2024 · 0 comments

Comments

@mnlevy1981
Copy link
Collaborator

While reviewing another PR, @klindsay28 pointed out that run_test_suite.sh sets ${MARBL_ROOT} but then relies on relative paths for arguments to various scripts (./MARBL_generate_settings_file.py -f ../defaults/json/settings_${shortname}.json, find ../../input_files/settings -type f, etc). Many relative paths to subdirectories of ${MARBL_ROOT}/tests/input_files/ so it might make sense to also define MARBL_INPUTDIR to reduce line length and improve readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant