-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] App crashed with WkWebView #2788
Comments
This plugin makes lots of JavaScript events while the map zoom is changing. Unfortunately, I can not to fix that. |
We could use a debounce function to throw away most events while zooming, what do you think? |
If you have a better idea, please try it. |
Sometimes it is difficult to reproduce and I have to continuously zoom for 10 seconds. Anyway I will try to implement debounce for it |
Yes. I tried both cases, but I had no problems.
|
Any update? |
Not yet, planning to add debounce func
…On Mon, Jun 1, 2020, 20:24 Masashi Katsumata ***@***.***> wrote:
Any update?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2788 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUBL5QHM23BR6QALRDDNJ3RUPP6DANCNFSM4NM62KQA>
.
|
Create PR #2795 |
Since I can't reproduce your issue at all (only reporting from you), I can't approved your PR |
We tested on iPhone 6, 7, XS the issue is reproducible Can somebody try to reproduce it as well? |
Hi, I cannot reproduce your issue on iPhone 6 but we've already used a debounce function uppon
|
I don't have |
I have no plan to buy One guessing reason of this problem is One of the possible solution for this is to use [before]
[after]
Again, I can not merge your PR until reproducing your issue on my side. |
@Mathieu-Castets @wf9a5m75 do you have our public apps (with latest version of the plugin) on the app store which I can test with mine iPhone 6? BTW iPhone XS has powerful Apple A12 and even so the issue is reproducible |
It does not make sense since the issue is inside on the execJS func:
I guess that cordova WKWebview has some memory leaking and calling JS callback every 3 milliseconds grab as much memory as it needs to crash the app |
I tried 10 times on both devices, but I could not reproduce your issue, and reporter is only you at this time. You don't need to merge your code mandatory. You already folk this repository, and you just left your code until I merge your code. |
I really appreciate if you create the test project that reproduce your issue 100% automatically.
|
BTW I checked the code and the plugin trigger two event at the same time: Regarding the app I reproduced the issue: Me and two colleagues testers reproduced the issue easily |
HelloMap.zip |
Thank you, but please don't past any zip file as described at here And I don't ask to share your |
UPDATE: I've installed Cordova iOS 6.0.0 and it looks like the issue is no more reproducible |
I'm submitting a ... (check one with "x")
OS: (check one with "x")
cordova information: (run
$> cordova plugin list
)Steps to reproduce:
cordova-plugin-wkwebview-engine
orionic-web-view-plugin
Since we have to use
WKWebView
insteadUIWebView
the issue is critical.Screen capture or video record:
Related code, data or error log (please format your code or data):
config.xml:
index.html:
Bab memory access issue:
Crash Report:
The text was updated successfully, but these errors were encountered: