Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing colours in UI #17

Open
RobJN opened this issue Jan 9, 2018 · 3 comments
Open

Confusing colours in UI #17

RobJN opened this issue Jan 9, 2018 · 3 comments

Comments

@RobJN
Copy link

RobJN commented Jan 9, 2018

It appears that the colours in these two pages mean different things:

[1] http://audit.osmz.ru/table/Asda-petrol-stations?all=1
[2] http://audit.osmz.ru/run/Asda-petrol-stations/594

In [1] red=tag deletion proposed by import, yellow=tag change proposed by import, green=new tag proposed by import.

In [2] green=tags proposed by import (new or changed), yellow=rejecting a proposed change and retaining an existing tag, red=rejecting a proposed change and having no tag.

Or is it that in [2] green=the current selected state based on the community result so far (with the import tag always being the lower of the two)?

@Zverik
Copy link
Contributor

Zverik commented Jan 10, 2018

No, in /run, green means you can move the point to a better location, and blue means the location is taken from OSM and cannot be changed.

I agree that green in this case is better be changed to some non-rgb colour. Do you have any ideas?

@RobJN
Copy link
Author

RobJN commented Jan 10, 2018

Actually I meant the colours used in the table left. But yes, the pointer green colour is again a different meaning for colour green.

@Zverik
Copy link
Contributor

Zverik commented Jan 11, 2018

Right, now I get it: you're talking about tags, not objects.

Yes, there is a slight difference, which, I think, helps notice changes. In case of the /table, you cannot choose which value to keep, so it differentiates between new and modified values. Finding the original value is not as easy in the table view, so with yellow and red dots, you know where to look.

In the validation mode, yellow and red colours aim to attract attention to tags which values are not modified, despite being proposed by an import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants