Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it correct to installation path for plugin files #179

Open
AGLExport opened this issue Oct 21, 2024 · 1 comment
Open

Is it correct to installation path for plugin files #179

AGLExport opened this issue Oct 21, 2024 · 1 comment
Labels
bug Something isn't working platform: Linux Linux platform issues
Milestone

Comments

@AGLExport
Copy link

AGLExport commented Oct 21, 2024

Describe the bug
I try to build maplibre-native-qt using yocto with meta-qt6.
These file install to /usr/ not a /usr/lib/.
/usr/plugins/geoservices/libqtgeoservices_maplibre.so
/usr/qml/MapLibre/qmldir
/usr/qml/MapLibre/libdeclarative_locationplugin_maplibre.so
/usr/qml/MapLibre/declarative_locationplugin_maplibre.qmltypes

To Reproduce
It's installation issue.

Expected behavior
I think so these installation path are correct.
/usr/lib/plugins/geoservices/libqtgeoservices_maplibre.so
/usr/lib/qml/MapLibre/qmldir
/usr/lib/qml/MapLibre/libdeclarative_locationplugin_maplibre.so
/usr/lib/qml/MapLibre/declarative_locationplugin_maplibre.qmltypes

Screenshots
No screenshots.

Platform information (please complete the following information):

  • OS: Linux
  • Qt version: 6.7.3
  • Version: 3.0.0

Additional context
I think do these setting is correct.

diff --git a/src/location/plugins/CMakeLists.txt b/src/location/plugins/CMakeLists.txt
index bbde029..ce37be1 100644
--- a/src/location/plugins/CMakeLists.txt
+++ b/src/location/plugins/CMakeLists.txt
@@ -77,10 +77,10 @@ install(
 install(
     TARGETS ${MLN_QT_GEOSERVICES_PLUGIN} ${GeoServicesPluginOutputTargets}
     EXPORT ${MLN_QT_NAME}LocationPluginGeoServicesTargets
-    ARCHIVE DESTINATION "plugins/geoservices"
-    LIBRARY DESTINATION "plugins/geoservices"
-    OBJECTS DESTINATION "plugins/geoservices"
-    RUNTIME DESTINATION "plugins/geoservices"
+    ARCHIVE DESTINATION "${INSTALL_PLUGINSDIR}/geoservices"
+    LIBRARY DESTINATION "${INSTALL_PLUGINSDIR}/geoservices"
+    OBJECTS DESTINATION "${INSTALL_PLUGINSDIR}/geoservices"
+    RUNTIME DESTINATION "${INSTALL_PLUGINSDIR}/geoservices"
 )
 
 # QtLocation QML extension plugin
@@ -214,21 +214,21 @@ install(
 install(
     TARGETS ${MLN_QT_QML_PLUGIN} ${QmlPluginOutputTargets}
     EXPORT ${MLN_QT_NAME}LocationPluginQmlTargets
-    ARCHIVE DESTINATION "qml/MapLibre"
-    LIBRARY DESTINATION "qml/MapLibre"
-    OBJECTS DESTINATION "qml/MapLibre"
-    RUNTIME DESTINATION "qml/MapLibre"
+    ARCHIVE DESTINATION "${INSTALL_QMLDIR}/MapLibre"
+    LIBRARY DESTINATION "${INSTALL_QMLDIR}/MapLibre"
+    OBJECTS DESTINATION "${INSTALL_QMLDIR}/MapLibre"
+    RUNTIME DESTINATION "${INSTALL_QMLDIR}/MapLibre"
 )
 install(
     FILES
         "${CMAKE_CURRENT_BINARY_DIR}/MapLibre/qmldir"
-    DESTINATION "qml/MapLibre"
+    DESTINATION "${INSTALL_QMLDIR}/MapLibre"
 )
 
 if(COMMAND qt_add_qml_module)
     install(
         FILES
             "${CMAKE_CURRENT_BINARY_DIR}/MapLibre/${MLN_QT_QML_PLUGIN}.qmltypes"
-        DESTINATION "qml/MapLibre"
+        DESTINATION "${INSTALL_QMLDIR}/MapLibre"
     )
 endif()
@ntadej
Copy link
Collaborator

ntadej commented Oct 21, 2024

Thanks for the report!

Yes, it seems that Linux installation paths are wrong when using system Qt.

@ntadej ntadej added bug Something isn't working platform: Linux Linux platform issues labels Oct 21, 2024
@ntadej ntadej added this to the 3.0.1 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform: Linux Linux platform issues
Projects
None yet
Development

No branches or pull requests

2 participants