We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_points_equal
is not
I noticed add_ring is not treating my closed ring like a closed ring:
ipdb> pt1 (19188372.37109346, -5402212.477493137) ipdb> pt2 (19188372.37109346, -5402212.477493137) ipdb> n > /Users/cdestigter/checkout/sno/sno/pyvendor/vector_tile_base/engine.py(314)_points_equal() 313 if pt1[0] is not pt2[0] or pt1[1] is not pt2[1] or (self._has_elevation and pt1[2] is not pt2[2]): --> 314 return False 315 return True ipdb> pt1[0] == pt2[0] True ipdb> pt1[0] is pt2[0] False
is not isn't the appropriate comparator here, it shoudl be !=. python doesn't guarantee two equal floats are the same float.
!=
The text was updated successfully, but these errors were encountered:
Fix bad float comparison
a9dcd4e
Fixes mapbox#19
As I understand, within an mvt the coordinates are all ints, no?
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
I noticed add_ring is not treating my closed ring like a closed ring:
is not
isn't the appropriate comparator here, it shoudl be!=
. python doesn't guarantee two equal floats are the same float.The text was updated successfully, but these errors were encountered: