Skip to content
This repository has been archived by the owner on Nov 25, 2019. It is now read-only.

rate error request reporting #55

Open
isiyu opened this issue Mar 11, 2017 · 2 comments
Open

rate error request reporting #55

isiyu opened this issue Mar 11, 2017 · 2 comments
Assignees

Comments

@isiyu
Copy link
Contributor

isiyu commented Mar 11, 2017

Currently tile requests are not returning 429 errors for ratelimits.
Pass this on from the requests so unity client can properly handle.

@david-rhodes mentioned you wanted this to be an exception that can be caught?

@isiyu isiyu added this to the open source milestone Mar 11, 2017
@wilhelmberg
Copy link
Contributor

I think throwing an exception is kind of harsh for communicating information about a request (rate error, network error, ...).

My thinking was more like UnityWebRequest does it:

  • HasError boolean property that can be easily checked if an error occured
  • Error property that is an object: if we choose this to be a string, an exception or a custom object (maybe wrapping an (inner) exception that has occurred) is yet to be discussed

@david-rhodes
Copy link
Contributor

@BergWerkGIS Agreed, and forgive me for misrepresenting what I actually intended--which is to encapsulate errors as objects. Ideally, all errors could be represented as objects, not just rate request errors.

In other words, I like your thinking!

@isiyu isiyu removed this from the open source milestone Apr 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants