Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing var for antiMeridian variable #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fknop
Copy link

@fknop fknop commented Jul 4, 2022

Should close #32

Copy link

@dereekb dereekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw you might consider changing it to be:

    allowAntiMeridian = allowAntiMeridian || false;

    var cacheKey = tileSize + String(allowAntiMeridian);
    if (!smCache[cacheKey]) {
        smCache[cacheKey] = new SphericalMercator({ size: tileSize, antimeridian: allowAntiMeridian });
    }

That way it is in line with how they used tileSize and are setting a default value to the input variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: antiMeridian is not defined
2 participants