Contradicting Assumptions about order of value and label in SQL Statement

[frwg]

data-manager/Component/FormItemFilter.php

Line 134 in ed8d712

@trigger_error("Sql for select item options is single-column. Use a statement that generates a value (first) and label (second).", E_USER_DEPRECATED);

Statement contradicts lines 146-149, which assume that label is the first element while value is the second one.

[werrolf]

Fixed in 1.2.7 and 2.0.5.

These versions also introduced support for direct column / expression aliases in select item choice queries for general sanity :]

SELECT
   'does not matter' AS "first",
   CONCAT_WS('Choice text:', "choice_label") AS label,
   id AS value,
  'does not matter either' AS "last"
FROM choices_table;